Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add plot to detection #1585

Merged
merged 20 commits into from
Mar 6, 2023
Merged

Add plot to detection #1585

merged 20 commits into from
Mar 6, 2023

Conversation

SkafteNicki
Copy link
Member

What does this PR do?

Fixes part of #1406
Had to make adjustments to the underlying plot function to also support dict of values.
Additionally, removed some imports from other files that are not used anymore.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the enhancement New feature or request label Mar 4, 2023
@SkafteNicki SkafteNicki added this to the v0.12 milestone Mar 4, 2023
@mergify mergify bot added the has conflicts label Mar 4, 2023
@mergify mergify bot removed the has conflicts label Mar 4, 2023
@SkafteNicki SkafteNicki mentioned this pull request Mar 4, 2023
Closed
11 tasks
Borda
Borda reviewed Mar 4, 2023
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you pls add printcreen :)

@mergify mergify bot requested a review from a team March 4, 2023 16:08
@codecov
Copy link

codecov bot commented Mar 6, 2023 •
edited
Loading

Codecov Report

Merging #1585 (a9740a0) into master (0d28f26) will decrease coverage by 0%.
The diff coverage is 90%.

Additional details and impacted files 
@@          Coverage Diff           @@
##           master   #1585   +/-   ##
======================================
- Coverage      88%     88%   -0%     
======================================
  Files         225     225           
  Lines       11905   11926   +21     
======================================
+ Hits        10529   10547   +18     
- Misses       1376    1379    +3

@Borda Borda enabled auto-merge (squash) March 6, 2023 14:27
@Borda Borda requested a review from awaelchli as a code owner March 6, 2023 14:42
@Borda Borda requested a review from ethanwharris as a code owner March 6, 2023 14:42
@mergify mergify bot added the ready label Mar 6, 2023
@Borda Borda disabled auto-merge March 6, 2023 19:24
@Borda Borda merged commit b753583 into master Mar 6, 2023
@Borda Borda deleted the plot/detection branch March 6, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@stancld stancld stancld approved these changes

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@awaelchli awaelchli Awaiting requested review from awaelchli

@ethanwharris ethanwharris Awaiting requested review from ethanwharris

Assignees

@SkafteNicki SkafteNicki

Labels
enhancement New feature or request ready
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@SkafteNicki @Borda @stancld